Remove usage of magic numbers in DynamicRaycastVehicleController#495
Open
JohnTheCoolingFan wants to merge 2 commits intodimforge:masterfrom
Open
Remove usage of magic numbers in DynamicRaycastVehicleController#495JohnTheCoolingFan wants to merge 2 commits intodimforge:masterfrom
JohnTheCoolingFan wants to merge 2 commits intodimforge:masterfrom
Conversation
| pub enum Axis { | ||
| X = 0, | ||
| Y = 1, | ||
| Z = 2, |
Contributor
There was a problem hiding this comment.
in case of 2d dimension, the ZAxis is invalid though, this line should be gated by a
Suggested change
| Z = 2, | |
| #[cfg(feature = "dim3")] | |
| Z = 2, |
ThierryBerger
added
C-Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage of magic numbers is discouraged in rust in favor of enums. I've replaced magic numbers that denote axes with an enum that can be converted to an integer when needed. The enum uses less bytes and does not allow invalid states.